Skip to content

Rate limit authenticated step-up auth routes#24

Merged
sidhujag merged 1 commit intomainfrom
fix/auth-step-up-rate-limit
Apr 25, 2026
Merged

Rate limit authenticated step-up auth routes#24
sidhujag merged 1 commit intomainfrom
fix/auth-step-up-rate-limit

Conversation

@sidhujag
Copy link
Copy Markdown
Member

Summary

  • Add a shared per-session authenticated step-up limiter for password/TOTP proof endpoints.
  • Apply it to verify-password, TOTP setup/enable/disable, change-password, and account deletion.
  • Require current-password proof in addition to the TOTP code when disabling TOTP.

Test plan

  • npm test -- auth.routes.test.js middleware/rateLimit.test.js
  • ReadLints on changed backend files

Made with Cursor

Apply a shared per-session limiter to password/TOTP step-up endpoints and require current-password proof when disabling TOTP.

Made-with: Cursor
@sidhujag
Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sidhujag sidhujag merged commit b162d56 into main Apr 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant