Let the candidate resize the code editor font - #226
Merged
Merged
Conversation
ColtenOuO
force-pushed
the
feat/editor-font-size
branch
from
October 2, 2026 21:16
0ab7556 to
3d03b36
Compare
jserv
reviewed
Oct 3, 2026
jserv
reviewed
Oct 3, 2026
jserv
reviewed
Oct 3, 2026
jserv
reviewed
Oct 3, 2026
The editor was fixed at 0.875rem, and browser zoom, the only way out, scales the problem statement and the preflight overlay with it. A- and A+ in the editor toolbar now step through six fixed sizes, kept in localStorage like the other preflight choices. The textarea, the highlight overlay and the gutter all read one custom property, so they cannot disagree on a size. The gutter width scales with it but never drops below the old 3.25rem, so a three-digit line number still fits at the largest size and a four-digit one at the smallest. A button at the end of the range is marked aria-disabled rather than disabled, so a keyboard user pressing it keeps focus. Ctrl with + and - is left alone because it is the browser's zoom. Close sysprog21#218
ColtenOuO
force-pushed
the
feat/editor-font-size
branch
from
October 3, 2026 10:24
3d03b36 to
0ea0b65
Compare
Contributor
|
Thank @ColtenOuO for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The code editor font was fixed at
0.875rem. The only way to change it was browser zoom, which also scales the problem statement and the preflight overlay. This addsA-/A+buttons to the editor toolbar that change only the editor and remember the choice between visits.Close #218
Summary by cubic
Lets candidates change the code editor font size with new A- / A+ buttons in the editor toolbar, instead of relying on browser zoom which also scales the problem statement and overlay. The choice is stored in localStorage and restored on the next visit.
aria-disabledat the ends so keyboard focus stays on the button, and browser tests verify every size keeps the layers aligned.Written for commit 0ea0b65. Summary will update on new commits.