Keep a drawn problem the new filter still shows - #227
Merged
jserv merged 1 commit intoOct 3, 2026
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ColtenOuO
force-pushed
the
fix/keep-pick-on-difficulty-change
branch
from
October 2, 2026 21:27
a5b7279 to
36eb1b7
Compare
jserv
reviewed
Oct 3, 2026
jserv
reviewed
Oct 3, 2026
Ticking or unticking a difficulty redrew the recommended problem even when its own level stayed checked, so widening the filter to look at Hard threw away the Medium problem already on screen. Only a problem picked by hand survived that. Now any problem whose level is still checked stays, and a redraw happens only when the change hides it. A kept draw is not turned into a hand pick, which would stand for good. It is held against the reports it was drawn from, since the roll no longer draws it and returning from the preflight would otherwise swap it. Once refreshed reports differ, as when the interview just passed it, the lobby draws again.
ColtenOuO
force-pushed
the
fix/keep-pick-on-difficulty-change
branch
from
October 3, 2026 10:30
36eb1b7 to
b7c541c
Compare
Contributor
|
Thank @ColtenOuO for contributing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checking or unchecking a difficulty in the lobby redrew the recommended problem even when that problem's level was still checked. For example, adding Hard to look at it replaced the Medium problem already on screen. Only a problem picked by hand was kept. Now any problem whose level is still checked is kept, and the lobby redraws only when the change hides it.
Summary by cubic
Fixes the lobby redrawing a recommended problem when a difficulty filter change still includes it. Previously only a problem picked by hand survived a filter change; a drawn problem was replaced even when its level stayed checked. Any problem whose level is still selected is now kept, and the lobby re-picks only when the change hides it. A kept drawn problem is held like a hand pick, except while the history is still loading, when the refreshed reports get to decide again.
Written for commit b7c541c. Summary will update on new commits.