Conversation
Bring GIMP up under the Motif build path and validate it against system Xlib via differential screenshot test. Adds the GIMP source patch series (compat/gimp-patches), the build fragments to fetch and build it (mk/gimp-motif.mk, mk/sdl.mk), and the differential runner (scripts/ run-gimp-differential-tests.py) with its fixtures and replay. Supporting compat fixes surfaced by the GIMP workload: - events.c: route inline-text events through a side queue so they survive sdl2-compat's event path, with thread-local wheel deltas - snapshot.c: write screenshots to a temp file and rename into place so readers never observe a truncated BMP - sdl-wrapper.c: side-queue-aware SDL event wrappers, undo push-time accounting on a full ring, and a shared atomic symbol-cache macro
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring GIMP up under the Motif build path and validate it against system Xlib via differential screenshot test. Adds the GIMP source patch series (compat/gimp-patches), the build fragments to fetch and build it (mk/gimp-motif.mk, mk/sdl.mk), and the differential runner (scripts/ run-gimp-differential-tests.py) with its fixtures and replay.
Supporting compat fixes surfaced by the GIMP workload:
Summary by cubic
Adds GIMP 0.54 (Motif) as a differential test target built against
libx11-compat, plus event, snapshot, and SDL loader‑path fixes uncovered by this workload to improve stability and test reliability.New Features
libx11-compat+ in‑tree Motif viamk/gimp-motif.mk; patch set incompat/gimp-patches(modern toolchain/LP64, updated PNG plug‑in, dropped TIFF).scripts/run-gimp-differential-tests.pywith fixtures and a startup replay; addedgimpjobs toci.ymlanddifferential.yml; README updated.mk/sdl.mk; tests set runtime loader paths sosdl2-compatresolves transitivelibSDL3libraries reliably.Bug Fixes
sdl2-compat; X event accounting stays correct; wheel deltas stored thread‑locally.rename()into place to avoid truncated BMP reads.wchar.h, useXmStringUnparsefor file dialogs, and defaultgimprcpath/name to run from the build tree.Written for commit 4b0e85b. Summary will update on new commits.