Conversation
SDL_ScaleMode and SDL_SetTextureScaleMode arrived in SDL 2.0.12, but the SDL2 wrapper thunk referenced them unguarded while every neighbor is version-gated. This broke the compat build on older SDL2 (Ubuntu focal ships 2.0.10). font.c already gates its only call site on the same version, so guarding the thunk leaves no undefined reference.
The existing XTest regression only drove a single childless window, so getContainingWindow's descent into child windows went untested even though it is the path a synthetic toolbox click takes: each tool icon is its own X sub-window. Add a parent with two spaced children and a bare gap, asserting a click routes to the geometrically correct child and a gap click reaches neither. Runs headless under SDL_VIDEODRIVER=dummy.
Wait for each Xvfb to accept connections instead of sleeping a fixed second, so a loaded headless runner no longer races the first capture into a spurious window-wait timeout. Make apt-get update best-effort so an unrelated broken third-party repo cannot abort the run under set -e. Split the contended differential capture onto a dedicated 15s wait-window replay, leaving the 8s budget for the single-Xvfb smoke job. Add draw-line to the differential. The legacy (32, 96) toolbox click landed in the inert Drawing label band that xfig 3.2.9 introduced, so a real X click selected no tool on system X11 and the capture had to be skipped. Re-point to the polyline cell at (55, 215) and commit the segment with a middle-click; the xdotool and internal backends now render the same line (MAE 0.034, threshold 0.16).
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Stabilizes xfig differential tests by waiting for Xvfb readiness and tolerating transient
apt-get updatefailures; adds a reliable draw‑line replay with correct tool coordinates. Also guardsSDL_SetTextureScaleModefor older SDL and adds an XTest that validates nested sub‑window routing.Bug Fixes
apt-get updatebest‑effort so unrelated repo errors don’t abort CI.SDL_SetTextureScaleModewrapper behind SDL 2.0.12 to fix builds on systems with older SDL.New Features
xfig-startup-differentialwith a 15s wait‑window to match concurrent captures.Written for commit 19a080b. Summary will update on new commits.