@W-22865124 Update Python Client library for 262#20
Merged
Conversation
Collaborator
|
I was wondering if we need to add some examples for the live workbook queries?? |
Adds three example-runner CLI args — --workbook-datasource-id, --global-session-header, --x-session-id — that, when all supplied, trigger an additional set of queries against a workbook datasource. Workbook queries reuse simple Query payloads via the new WORKBOOK_QUERY_FUNCTIONS list and are dispatched on a clone of the VizQLDataServiceClient carrying Global-Session-Header and X-Session-Id headers. Includes a new VizQLDataServiceClient.with_headers(...) public method that returns a non-mutating clone with merged headers (via attrs.evolve on the inner AuthenticatedClient, preserving cookies, timeout, follow_redirects, httpx_args, and raise_on_unexpected_status). Tests cover payload shapes, request serialization, args gating (including whitespace-only rejection), CRLF/NUL header validation, help-text wording, and end-to-end dispatch through sync_examples.execute and async_examples.execute. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
yunlong-zhang-sfdc
left a comment
Collaborator
There was a problem hiding this comment.
can we also add a section in contributing.md to have the new examples.py command?
4 similar comments
yunlong-zhang-sfdc
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Updating the python client for the 262 release of VizQL Data Service.
Fixes:
Type of Change
Please delete options that are not relevant.
Checklist
Screenshots (if applicable)
Add screenshots or code snippets if this PR changes UI or major behavior.
Additional Notes
Anything else reviewers should know.