Repository navigation
Shell completions never ask for a login (fixes brew install) - #3
Merged
Merged
Conversation
`brew install taelio/tap/tael` failed at the last step: the formula runs `tael completion bash|zsh|fish` to generate completions, and the CLI answered "not logged in" (exit 3). Only cobra's hidden __complete helpers were exempt from the login gate; the user-facing generator was not, and its shells are named bash/zsh/fish, so a name check on the leaf never saw it. The gate now walks up to the `completion` command directly under the root. Everything else still needs a login. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T6qrk4NVPAGeac6YuALp1M
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew install taelio/tap/taelfails at its last step: the formula'sgenerate_completions_from_executablerunstael completion bash|zsh|fish, and the CLI refuses with "not logged in" (exit 3). Only cobra's hidden__completehelpers were exempt from the login gate — the user-facing generator was not, and since its subcommands are namedbash/zsh/fish, a name check on the leaf never saw it.The gate now walks up to the
completioncommand directly under the root (cobra adds it at execution time, so it cannot carry the annotation). Everything else still needs a login; a nested command that merely happens to be calledcompletionis not exempt.Verified:
go vet, gofmt, tests green;TAEL_API_TOKEN= tael completion bashprints the script,tael appswithout a login still exits 3.