Skip to content

tailcat: mark magicsock's network up before the first netcheck #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bradfitz merged 1 commit into from
Sep 28, 2026
Merged

tailcat: mark magicsock's network up before the first netcheck #138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion tailcat.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1628,6 +1628,14 @@ func (lb *locoBackend) Start() error {
mc := lb.sys.MagicSock.Get()
lb.logf("disco pub key: %v", mc.DiscoPublicKey())

// Mark the network up before SetPrivateKey and SetDERPMap, which
// start endpoint updates in the background. With no non-loopback
// interface (as in the Nix build sandbox) magicsock starts with
// the network down, and an endpoint update that runs while it is
// still down skips netcheck and never picks a home DERP. A server
// then isn't reachable through DERP until the periodic re-STUN
// 20-26s later, long after clients give up.
mc.SetNetworkUp(true)
mc.SetPrivateKey(lb.priv)
mc.SetDERPMap(lb.dm)

Expand Down Expand Up @@ -1683,7 +1691,6 @@ func (lb *locoBackend) Start() error {
mc.SetNetworkMap(nm.SelfNode, nm.Peers)
e.SetSelfNode(nm.SelfNode)
lb.sys.Netstack.Get().UpdateNetstackIPs(nm)
mc.SetNetworkUp(true)
lb.logf("NetworkMap: %v", logger.AsJSON(nm))

// Install the live per-peer config sources. WireGuard peers are
Expand Down
Loading