Repository navigation
makefile: fetch tailscale.com via the module proxy in update-oss - #880
Merged
Merged
Conversation
kari-ts
approved these changes
Sep 21, 2026
The update-oss target set GOPROXY=direct for the whole go get because
proxy.golang.org caches branch resolution and often returned a stale
commit for tailscale.com@main. But direct mode also made every
dependency a slow git clone.
Instead, resolve the tip of main ourselves with git ls-remote and go get
that exact commit. The proxy fetches explicit revisions on demand, so
tailscale.com and all of its dependencies come from the proxy. If that
fails, fall back to GONOPROXY=tailscale.com so only tailscale.com is
fetched directly while everything else still uses the proxy.
This is motivated by a wireguard-go tag that changed after
sum.golang.org grabbed it, so:
go: upgraded golang.zx2c4.com/wireguard/windows v0.5.3 => v1.0.1: error finding sum for golang.zx2c4.com/wireguard/windows@v1.0.1: golang.zx2c4.com/wireguard/windows@v1.0.1: verifying module: checksum mismatch
downloaded: h1:zRLGRx84kiOcxqkYLoeKYCQNBO2tKYOKXu7AvlSZ6h4=
sum.golang.org: h1:eOxiDVbywPC+ZQqvdCK7x+ZwWXKbYv50TtH8ysFIbw8=
Instead, get it from proxy.golang.org which doesn't match the upstream
git tag anymore, but passes the sum.golang.org validation.
Fixes tailscale/corp#48607
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Change-Id: I7c2e4f9a1b3d5e6f8a0b2c4d6e8f0a1b3c5d7e9f
bradfitz
force-pushed
the
bradfitz/update-oss-proxy
branch
from
September 21, 2026 22:35
8b8ae46 to
a048cf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The update-oss target set GOPROXY=direct for the whole go get because
proxy.golang.org caches branch resolution and often returned a stale
commit for tailscale.com@main. But direct mode also made every
dependency a slow git clone.
Instead, resolve the tip of main ourselves with git ls-remote and go get
that exact commit. The proxy fetches explicit revisions on demand, so
tailscale.com and all of its dependencies come from the proxy. If that
fails, fall back to GONOPROXY=tailscale.com so only tailscale.com is
fetched directly while everything else still uses the proxy.
This is motivated by a wireguard-go tag that changed after
sum.golang.org grabbed it, so:
Instead, get it from proxy.golang.org which doesn't match the upstream
git tag anymore, but passes the sum.golang.org validation.
Fixes tailscale/corp#48607