Skip to content

android: make HealthNotifier init-order test catch the NPE #889

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kradalby merged 1 commit into from
Oct 7, 2026
+8 −2
Merged

android: make HealthNotifier init-order test catch the NPE #889

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions android/src/test/kotlin/com/tailscale/ipn/ui/notifier/HealthNotifierTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import com.tailscale.ipn.ui.model.Health.UnhealthyState
import com.tailscale.ipn.ui.model.Ipn
import com.tailscale.ipn.util.TSLog
import com.tailscale.ipn.util.TSLog.LibtailscaleWrapper
import kotlinx.coroutines.CoroutineExceptionHandler
import kotlinx.coroutines.CoroutineScope
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.ExperimentalCoroutinesApi
Expand Down Expand Up @@ -131,15 +132,20 @@ class HealthNotifierTest {
* immediately calls dropAllWarnings() (reading currentWarnings) when the initial ipn state is not
* Running. If currentWarnings/currentIcon are declared after the init block, that read hits a
* null StateFlow and NPEs. Using Dispatchers.Unconfined runs the launched coroutine eagerly
* inside the constructor, deterministically reproducing the race on the old ordering.
* inside the constructor, deterministically reproducing the race on the old ordering. The NPE
* surfaces as an uncaught coroutine exception, which kills the process on Android but only gets
* printed on the JVM, so it must be captured explicitly for the test to fail.
*/
@Test
fun constructionWithNonRunningStateDoesNotCrash() {
val scope = CoroutineScope(Dispatchers.Unconfined)
var uncaught: Throwable? = null
val scope =
CoroutineScope(Dispatchers.Unconfined + CoroutineExceptionHandler { _, e -> uncaught = e })
try {
val healthFlow = MutableStateFlow<Health.State?>(healthState(derpWarning()))
val ipnFlow = MutableStateFlow(Ipn.State.Stopped)
val notifier = HealthNotifier(healthFlow, ipnFlow, scope)
uncaught?.let { throw it }
assertTrue(notifier.currentWarnings.value.isEmpty())
assertNull(notifier.currentIcon.value)
} finally {
Expand Down
Loading