Conversation
|
| inputSourceMap: map, | ||
| drafts: { | ||
| customMedia: true, | ||
| scrollNavigationControls: true, |
There was a problem hiding this comment.
Warning behavior lacks test coverage
The new option is intended to stop warnings for :target-current, :target-before, and :target-after, but the optimizer has no direct test of its warning output. A later change could bring those warnings back without being caught. Please test the warning behavior with both minified and non-minified output.
Knowledge Base Used: Node API and compilation services
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughThe CSS optimization transform now enables Lightning CSS’s Priority: ⬇️ Low Merge Risk: ⚪ Minimal · up to The optimizer can now handle the three scroll-navigation pseudo-classes without the reported warnings. No concrete merge-blocking risk remains. Architecture SummaryArchitecture risk: 🔵 Low · up to The change affects 2 systems. Changed systems: Architecture concerns Review detailsSystems and components
Before / after behavior
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
lightningcss 1.33.0 (parcel-bundler/lightningcss#1185) parses
:target-current,:target-beforeand:target-afteronly whendrafts.scrollNavigationControlsis set.optimize.tssets onlycustomMedia, so any stylesheet using these CSS Overflow 5 selectors prints "'target-current' is not recognized as a valid pseudo-class" on every build. The rule is kept only becauseerrorRecoveryis on. This turns the draft on.