Conversation
A served engine reported an unknown footprint because its files live in a container this process cannot walk, so the disk rows were empty for every rival and the resource claims had nothing to stand on. Each container spec now names the directory its server keeps the database in, and du runs inside the container to size it. The reading is taken twice, after the load and after the measured run, by one function per plane, and the loader's own figure is used only where the harness cannot measure the store itself. That matters beyond the served engines: an adapter answers for whatever it thinks its store is, one file for zu and a whole directory for ladybug, and the growth figure was that against a directory walk taken here. Both ends are the same ruler now.
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #56, the disk half of the resource measurement section.
A served engine reported an unknown footprint because its files live in a container this process cannot walk. That is why ladybug and neo4j returned -1 BytesOnDisk and why the disk rows of the resource table were empty for every rival. Each container spec now names the directory its server keeps the database in (/data for neo4j, /var/lib/memgraph, /var/lib/postgresql, /data/db), and du runs inside the container to size it.
The reading is taken twice, after the load and after the measured run, by one function chosen per plane, and the loader's own figure is used only where the harness cannot measure the store itself. That matters beyond the served engines. An adapter answers for whatever it thinks its store is, which is one file for zu and a whole directory for ladybug, and the growth figure was that number against a directory walk taken here. Both ends are the same ruler now, so the growth is the bytes the measured run made durable rather than a difference between two rulers.
du runs with --apparent-size so the count means what the local planes report by adding up file sizes, with a kilobyte-block fallback for an image without GNU coreutils.
Measured on this box, linkbench smoke count 400 concurrency 4, zu inproc against ladybug inproc:
zu's store after load was the size of bench.zu1 before this and is the size of the database directory now, so the growth figure shrinks rather than grows: it no longer counts the sidecar files as bytes the run added.
No engine adapter changed. go test ./... green.