Say what the DuckDB audit found this time - #408
Merged
Merged
Conversation
The comparison table had eight rows that were true when it was written and are not now. Node has transactions, an appender, register, bulk load, a columnar read, prepared statements, explain and profile, and both clients have a connection with no file behind it. A page that still says none of that is a page a reader would be misled by, and it is the page the milestone is scored against. Section 5 is put in the past tense against each line of its own list, which is the honest shape for it: the list was right, and what it asked for happened. Section 7's items 3 and 4 are marked done. Item 6 loses its first clause and keeps the four that are still open.
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The comparison table in
docs/clients/duckdb.mdhad eight rows that were true when the audit was written and are not now, and it is the page the DX milestone is scored against.Node has gained transactions, an appender,
register, bulk load, a columnar read, prepared statements,explainandprofilesince the table was last touched, and both clients now have a connection with no file behind it, from #405, tamnd/zu-python#27 and tamnd/zu-node#20.Three changes:
The table says what each client has today. The in-memory row goes from "owed, and the
':memory:'behaviour is a bug" to done. Seven Node rows go fromnoneto what the client actually exports. The rows that are still owed are still owed and say so:fetchmanyfor the DB-API, Arrow itself for Node,fetchnumpy, a progress callback in Node, andcursor()in both.Section 5 goes into the past tense against each line of its own list, which is the honest shape for it. The list was right, and what it asked for happened, so each bullet now names the thing that answered it. The one row still open,
rowsReadand a progress callback, is marked as the one row still open.Section 7's items 3 and 4 are marked done, item 6 loses its first clause and keeps the four small things that are still owed, and the closing paragraph drops the sentence about the scorecard being blocked on items 3 and 4.
No code changes.