The progress row is done - #418
Merged
Merged
Conversation
rowsRead and progress() landed in zu-node, so the last of the small ones is closed: both clients can now say how far the statement running is, and Node says it with a timer over the same counter Python reads as a property. The counter also turned out never to have been put back down between statements in Node, which is fixed there.
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rowsReadandprogress()landed in zu-node in tamnd/zu-node#22, so the audit's progress row and the last of item 6's small ones are closed. Python answersrows_readas a property and Node answersrowsReadthe same way, withprogress()as a timer over it, and neither client calls into its runtime from the thread doing the scanning.The counter also turned out never to have been put back down between statements in Node, so it had been counting a connection's whole life rather than one statement. That is fixed in the same change, at the three places a connection becomes a statement's.