Skip to content

fix(release): canonicalize macOS smoke paths #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
drewstone merged 1 commit into from
Aug 11, 2026
Merged

fix(release): canonicalize macOS smoke paths #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions scripts/release/smoke-package.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { spawn } from 'node:child_process'
import { createHash } from 'node:crypto'
import { mkdir, mkdtemp, readdir, readFile, rm, stat, writeFile } from 'node:fs/promises'
import { mkdir, mkdtemp, readdir, readFile, realpath, rm, stat, writeFile } from 'node:fs/promises'
import { tmpdir } from 'node:os'
import { basename, dirname, join, relative, resolve } from 'node:path'
import { fileURLToPath } from 'node:url'
Expand Down Expand Up @@ -140,7 +140,7 @@ const expectedArchitecture =
assert(artifactRootValue, '--artifact-root is required')
const artifactRoot = resolve(artifactRootValue)
const proof = JSON.parse(await readFile(join(artifactRoot, 'w6', 'package-proof.json'), 'utf8'))
const smokeRoot = await mkdtemp(join(tmpdir(), 'braid-platform-smoke-'))
const smokeRoot = await realpath(await mkdtemp(join(tmpdir(), 'braid-platform-smoke-')))
let smokeResult

try {
Expand Down
6 changes: 6 additions & 0 deletions test/scripts.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -686,10 +686,16 @@ test('release keys stay isolated while publication uses the installed product',

const candidateSmoke = job('platform-smoke', 'publish')
const registrySmoke = job('post-publish-smoke', 'finalize')
const packageSmoke = await readFile('scripts/release/smoke-package.mjs', 'utf8')
assert.match(candidateSmoke, /name: Install and use the exact candidate/u)
assert.match(candidateSmoke, /node scripts\/release\/smoke-package\.mjs/u)
assert.match(registrySmoke, /name: Download and use the registry package/u)
assert.match(registrySmoke, /node scripts\/release\/smoke-package\.mjs/u)
assert.match(
packageSmoke,
/const smokeRoot = await realpath\(await mkdtemp\(/u,
'Package smoke must use a physical path for protected storage on macOS',
)

const finalize = job('finalize', 'endorse-final')
assert.match(finalize, /name: Validate candidate and registry use/u)
Expand Down