running: detect missing tarantool through wrapped errors#1304
Open
bigbes wants to merge 1 commit into
Open
Conversation
The integrity dummyRepository.Read now wraps the os.Open error with
fmt.Errorf("open %q: %w", ...). baseInstance.Run checked the result with
the legacy os.IsNotExist, which does not unwrap, so a missing tarantool
binary leaked a raw 'open "": no such file or directory' message instead
of the friendly 'tarantool executable is not found'.
Use errors.Is(err, os.ErrNotExist) so the wrapped not-exist error is
recognized again. Fixes test_run_without_tarantool on v3. so .
bigbes
force-pushed
the
bigbes/gh-no-tarantool-not-found-msg
branch
from
ea425b7 to
854ebc9
Compare
sssciel
approved these changes
Jun 1, 2026
Mockird31
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integrity dummyRepository.Read now wraps the os.Open error with fmt.Errorf("open %q: %w", ...). baseInstance.Run checked the result with the legacy os.IsNotExist, which does not unwrap, so a missing tarantool binary leaked a raw 'open "": no such file or directory' message instead of the friendly 'tarantool executable is not found'.
Use errors.Is(err, os.ErrNotExist) so the wrapped not-exist error is recognized again. Fixes test_run_without_tarantool on v3.