Repository navigation
Use runner measurements for CI test allocation - #973
Merged
Merged
Conversation
PR #973: chore: measure CI cost of the REPL include regression1 files, +1252 / -1110 Scope🔴 PR has 2362 lines changed. Split into focused PRs. 🟡 2362 lines changed. PRs under 400 receive more thorough review. Structural✅ No structural bloat detected. Slop✅ Slop indicators look low. Static Analysis✅ Oxlint found no issues. CorrectnessNo extraneous code patterns detected. |
taras
marked this pull request as ready for review
October 21, 2026 11:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
CI needs measured costs for the REPL include regression delivered in #972 so weighted test shards can account for it alongside the rest of the corpus.
What changes
Before:
repl-include-pty.test.tshas no recorded weight and receives the conservative maximum-weight fallback for each runtime.After: CI allocation uses its measured Deno, Node and Bun costs, together with refreshed per-file weights for the same corpus. This updates
test-weights.jsonwith the successful runner artifact byte for byte.Generated or mechanical changes
The artifact comes from Measure test weights run 39556424450, attempt 1, on
ubuntu-latest. Its provenance remains source commita4907b468777e4112f87ff80d26f0e692fa73e35, measured with Deno 2.9.5, Node v22.23.3 and Bun 1.4.0. That source tree equals the merged #972 tree and this follow-up's parent tree.How to verify it
deno task test scripts/tests/test-weights.test.ts scripts/tests/measure-test-weights.test.tspassed all 22 steps. Both original reviewers independently returned PASS for signed headb403958b23e4bc9e486525fd460aa6e280bc624d.green, at that same head.Scope
Only
test-weights.jsonchanges. Test selection, exclusions, runner commands, shard counts, dependencies and product behavior keep their existing contracts. This PR applies measurement data; it adds no measurement mechanism or feature implementation.Scope confirmation