feat: add nix package - #103
Conversation
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8fe1f923fb
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| On NixOS or another system with Nix installed: | ||
|
|
||
| ```sh | ||
| nix profile install github:tarik02-org/t3code-cli |
There was a problem hiding this comment.
Restrict the Nix installation claim to x86_64 Linux
On aarch64 Linux or either Darwin architecture, this documented command cannot resolve a default package because flake.nix defines packages.default only for x86_64-linux. Either expose the package for the additional supported Nix systems or state the architecture restriction here so users on other systems are not given a nonfunctional installation command.
Useful? React with 👍 / 👎.
|
The Nix source pin or pnpm dependency hash is stale. Apply this change to the pull request: diff --git a/flake.lock b/flake.lock
index b78a9e4..547b4a6 100644
--- a/flake.lock
+++ b/flake.lock
@@ -42,17 +42,17 @@
"upstream-t3code": {
"flake": false,
"locked": {
- "lastModified": 1786361740,
- "narHash": "sha256-qZi9hMGzqpmnpqvvVtsQvkZIiVqTgOMWv1y15MiSAYg=",
+ "lastModified": 1786783355,
+ "narHash": "sha256-G6sttzF/SChyPCzR7nFIEMFnNjrBul0bP4pa7kS2M9M=",
"owner": "pingdotgg",
"repo": "t3code",
- "rev": "3b72d17cbca691f0b64e6d4a10c9e349f42873a5",
+ "rev": "f0ebc628c6dd83fd0c7963078ad7778ce6028d0c",
"type": "github"
},
"original": {
"owner": "pingdotgg",
"repo": "t3code",
- "rev": "3b72d17cbca691f0b64e6d4a10c9e349f42873a5",
+ "rev": "f0ebc628c6dd83fd0c7963078ad7778ce6028d0c",
"type": "github"
}
}
diff --git a/flake.nix b/flake.nix
index b15ce7a..3a080b6 100644
--- a/flake.nix
+++ b/flake.nix
@@ -6,7 +6,7 @@
nixpkgs-darwin.url = "github:NixOS/nixpkgs/nixpkgs-26.05-darwin";
upstream-t3code = {
- url = "github:pingdotgg/t3code/3b72d17cbca691f0b64e6d4a10c9e349f42873a5";
+ url = "github:pingdotgg/t3code/f0ebc628c6dd83fd0c7963078ad7778ce6028d0c";
flake = false;
};
}; |
What changed
nix profile.Why
Keeping this derivation in a consumer repository allowed the CLI source, upstream source, and pnpm dependency hash to drift independently. The package now lives beside the lockfile and submodule that define its build. Pull requests receive the required Nix changes before merge instead of a follow-up repair PR.
Verification
nix build .#packages.x86_64-linux.default --builders ''nix flake check --all-systems --no-buildt3cli --versionnixfmt --check flake.nix nix/package.nixactionlint