Skip to content

Add CLAUDE.md for Claude Code guidance#24

Merged
tbeason merged 2 commits into
mainfrom
worktree-claude-md-init
Jun 3, 2026
Merged

Add CLAUDE.md for Claude Code guidance#24
tbeason merged 2 commits into
mainfrom
worktree-claude-md-init

Conversation

@tbeason

@tbeason tbeason commented Jun 2, 2026

Copy link
Copy Markdown
Owner

Summary

Adds a CLAUDE.md at the repo root to orient future Claude Code sessions. Based on latest main (post #22/#23).

Covers, repo-specifically (no generic boilerplate):

  • Commands — full offline test suite, single-test-file invocation, build, the separate benchmark/ and docs/ projects, and the DATABENTO_LIVE_TESTS=1 gating + mock-gateway/mock-dispatcher test design.
  • Architecture — the DBN delegation boundary (this package owns wire protocols, not record layouts); the Historical/Live clients; Live typed vs untyped modes; the TCP read stack (CountingIOBufferedReaderDBNDecoder); the reconnect supervisor (channel-ownership-by-policy, immediate-then-backoff schedule, replay-on-reconnect, terminal errors); and single-connection multi-schema capture + zstd-frame durability.
  • Conventions for changes — comment style, export-list + test expectations, CHANGELOG, Julia 1.12 / CI matrix.

🤖 Generated with Claude Code

Documents the DBN delegation boundary, the two clients, Live typed/untyped modes, the TCP read stack, the reconnect supervisor design, and multi-schema capture durability — plus test/build/benchmark/docs commands and the DATABENTO_LIVE_TESTS gating.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e1a338315b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread CLAUDE.md
julia --project=benchmark benchmark/runbench.jl --tiers=small # override size tiers

# Docs (Documenter.jl)
julia --project=docs docs/make.jl

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Add the required docs environment setup command

In a fresh checkout this command cannot build the docs as documented: docs/make.jl immediately imports Documenter and DatabentoAPI, but docs/Project.toml has no manifest or local [sources] entry and this command never instantiates the docs environment or develops the repository package into it. The existing documentation workflow explicitly performs Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate() first in .github/workflows/documentation.yml:30-34. Include that preparation step in this guidance so future sessions can run the advertised docs build successfully.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch — fixed in 1dc47dd. The docs section now runs the env-setup step from documentation.yml before building:

julia --project=docs -e 'using Pkg; Pkg.develop(PackageSpec(path=pwd())); Pkg.instantiate()'
julia --project=docs docs/make.jl

Codex review flagged that 'julia --project=docs docs/make.jl' fails on a fresh checkout — docs/Project.toml has no manifest and the repo package isn't developed into it. Add the Pkg.develop + Pkg.instantiate step that .github/workflows/documentation.yml runs first.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@tbeason
tbeason merged commit c68b913 into main Jun 3, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant