Repository navigation
Claude/planreview phase 2 d5b0bc - #2
Merged
Merged
Conversation
… docs - FastAPI no longer mounts web/dist; serves only /api, /docs, /openapi.json - web/src/api.js: single client, stable ApiError shape, no auto-retry, honest timeout/abort messages; console migrated to it - Console renders EVALUATION_ERROR as a technical failure - Vite proxies /api, /docs, /openapi.json to FastAPI (strictPort 5173) - start.ps1 / start-frontend.ps1, README and beginner test updated - docs/api_contract.md and docs/phase3_migration_map.md - Tests: API independence, JSON 404, Vite origin; 22 vitest client tests Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
… API examples Gaps found by comparing with the separate C:\Dev attempt (read-only): - tools/test_phase2_smoke.py: separate FastAPI + Vite process smoke test - tests/test_api.py: OpenAPI schema lists task endpoints - docs/api_contract.md: observed real error/gate examples - README: document the smoke script Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Address the dependency lock mismatch, cross-platform smoke-test interpreter path, and /apply timeout handling.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Separates the FastAPI backend from the Vite frontend and adds centralized API handling, tests, error UI, and development documentation.
Changes:
- Added Vite proxy configuration and frontend startup workflow.
- Added API client, error handling, and Vitest coverage.
- Added backend and smoke tests.
- Updated dependencies and Phase 2 documentation.
| File | Summary |
|---|---|
web/vite.config.js |
Configures Vite server, proxy, and tests. |
web/src/styles.css |
Styles evaluation-error states. |
web/src/main.jsx |
Integrates API helpers and evaluation-error display. |
web/src/api.test.js |
Tests API client behavior. |
web/src/api.js |
Centralizes HTTP requests and error handling. |
web/package.json |
Adds frontend test tooling. |
web/package-lock.json |
Locks frontend dependencies. |
tools/test_phase2_smoke.py |
Adds FastAPI/Vite integration smoke testing. |
tests/test_api.py |
Tests backend API behavior. |
start.ps1 |
Starts the backend with validation. |
start-frontend.ps1 |
Starts the Vite frontend. |
requirements.txt |
Adds Ollama support. |
README.md |
Documents Phase 2 setup and verification. |
engine/api.py |
Removes frontend static hosting. |
docs/phase3_migration_map.md |
Documents future frontend migration boundaries. |
docs/api_contract.md |
Documents the backend API contract. |
BEGINNER_HTTP_TEST.md |
Updates local usage instructions. |
Files not reviewed (1)
- web/package-lock.json: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+55
to
+56
| [str(ROOT / ".venv/Scripts/python.exe"), "-m", "uvicorn", "engine.api:app", | ||
| "--host", "127.0.0.1", "--port", "8000"], |
| canonicalize: (id, o) => post(`/tasks/${enc(id)}/canonicalize`, {}, o), | ||
| evaluate: (id, o) => post(`/tasks/${enc(id)}/evaluate`, {}, o), | ||
| resolve: (id, decisions, o) => post(`/tasks/${enc(id)}/resolve`, decisions, o), | ||
| apply: (id, o) => post(`/tasks/${enc(id)}/apply`, {}, o), |
tchxm
added a commit
that referenced
this pull request
Sep 20, 2026
Claude/planreview phase 2 d5b0bc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.