feat(import): support multi-vendor place imports#91
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
I think we can totally remove all the category -> icon mapping. That was intended when we were going to temporarily display imported places, which we don't do. |
|
Reviewed + ran tests on the pinned 1.93.0 toolchain. One blocker.
Two worth a line in the PR:
Vendor centralization, the Happy to write the regression test or draft the fix - ping @rockstardev to point me at it. |
Need
Currently, the
/importendpoint only supports Square as an origin. Multiple other wallets have expressed interest in using this endpoint to leverage the verification and quality controls provided by taggers and avoid the pitfalls associated with direct OSM integration.Summary
*wildcard support for all origins.Validation
cargo fmtcargo clippy -- -D warningscargo testOut Of Scope