Skip to content

fix(core): let answers land on a failed-then-resumed run #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sergeyzenchenko merged 1 commit into from
Sep 4, 2026
Merged

fix(core): let answers land on a failed-then-resumed run #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions packages/core/src/engine.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1775,6 +1775,11 @@ export class Engine implements EngineHost {
else if (rec.ev.type === "run.completed") terminal = "complete";
else if (rec.ev.type === "run.failed") terminal = "failed";
else if (rec.ev.type === "run.cancelled") terminal = "cancelled";
// A resume re-opens the run: a run.status back to executing after a
// terminal event means the run is live again and answers must land —
// otherwise a failed-then-resumed run can never have a gate answered
// and any step waiting on one deadlocks into its timeout.
else if (rec.ev.type === "run.status" && rec.ev.status === "executing") terminal = undefined;
}
// An external process can land a TERMINAL event (a CLI's cancel beside
// this daemon) between the pending check and the append: the lost CAS
Expand Down Expand Up @@ -1824,6 +1829,10 @@ export class Engine implements EngineHost {
if (r.ev.type === "run.completed") terminal = "complete";
else if (r.ev.type === "run.failed") terminal = "failed";
else if (r.ev.type === "run.cancelled") terminal = "cancelled";
// Mirror the live-run fold: a resume (run.status back to executing)
// re-opens the run, so a historical terminal event must not block
// answers forever.
else if (r.ev.type === "run.status" && r.ev.status === "executing") terminal = undefined;
}
if (terminal !== undefined) {
throw new Error(`run ${runId} is already ${terminal} — resume it before answering`);
Expand Down
Loading