fix: parse boolean connection string options correctly#1861
Merged
dhensby merged 1 commit intoMay 14, 2026
Conversation
Non-standard boolean options (useUTC, stream, parseJSON) were not part of the MSSQL_SCHEMA, so they were passed through as raw strings by the connection string parser. This caused values like "False" to be coerced to true via the `!!` operator (since any non-empty string is truthy). Extend the MSSQL_SCHEMA with these node-mssql-specific keys so that toSchema() handles the string-to-boolean conversion. Also add request timeout as a number type. Closes tediousjs#1860 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
🎉 This PR is included in version 12.5.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
useUTC=Falsein a connection string is incorrectly parsed astrue.The
useutc,stream, andparsejsonkeys are not part of the upstreamMSSQL_SCHEMA, sotoSchema()does not include them in its output. They are then added back from the raw parse result as strings (e.g."False"). The existing!!valuecoercion converts any non-empty string totrue, making it impossible to disable these options via connection strings.Fix
Extend
MSSQL_SCHEMAwith the node-mssql-specific keys (useutc,stream,parsejsonasboolean,request timeoutasnumber) so thattoSchema()handles the type conversion automatically — the same way it already handlesencrypt,trustservercertificate, etc.Tests
Added 7 tests covering
True/False/falsevariations foruseUTC,stream, andparseJSON.Closes #1860