ci: enforce gofmt and docs freshness checks - #3244
Merged
tekton-robot merged 1 commit intoSep 14, 2026
Merged
Conversation
tekton-robot
added
the
release-note-none
tekton-robot
added
the
size/M
divyansh42
force-pushed
the
ci/enforce-docs-golden-checks
branch
from
September 12, 2026 12:18
3db9901 to
0c5781e
Compare
divyansh42
changed the title
Fix a long-standing bug where the gofmt step silently swallowed failures by setting failed=1 but never exiting with it. Add hack/verify-generated.sh which runs make docs and uses git status --porcelain to detect both modified and newly generated files in docs/. Wire it as a second step in the existing generated CI job so docs staleness is caught without adding a separate job. Signed-off-by: divyansh42 <diagrawa@redhat.com> Assisted-by: Claude Sonnet 4.6 (via Claude Code)
divyansh42
force-pushed
the
ci/enforce-docs-golden-checks
branch
from
September 12, 2026 12:29
f288a74 to
c3f805b
Compare
Member
Author
Member
|
/lgtm |
vdemeester
approved these changes
Sep 14, 2026
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix a long-standing bug where the
gofmtCI step setfailed=1onformatting violations but never exited with it — this check has been
passing vacuously since the workflow was first introduced.
Add
hack/verify-generated.shwhich runsmake docsand usesgit status --porcelainto detect both modified and newly generatedfiles in
docs/. Wire it as a second step inside the existinggeneratedCI job so docs staleness is caught without adding aseparate job.
Submitter Checklist
make checkmake generatedRelease Notes