Skip to content

Add connectivity rule support for azure#91

Merged
david049 merged 4 commits into
mainfrom
dliu/azurecr
Jul 8, 2026
Merged

Add connectivity rule support for azure#91
david049 merged 4 commits into
mainfrom
dliu/azurecr

Conversation

@david049

@david049 david049 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

What was changed

adds connectivity rule support for azure, bumps to latest sdk

Why?

Checklist

  1. Closes

  2. How was this tested:

local tested
3. Any docs updates needed?


Note

Medium Risk
Touches cloud connectivity creation paths and a major SDK bump with broad mock/API surface changes; misconfigured Azure/AWS/GCP flags could create invalid rules, but scope is limited to CLI connectivity commands.

Overview
Adds Azure private connectivity to temporal cloud connectivity private create via a new --azure-pe-resource-id flag, and passes that ARM resource ID through to PrivateConnectivityRule when creating rules.

Private create is no longer AWS-only: --connection-id is optional (still used for AWS/GCP), while --region remains required. Help text and commands.yml now document AWS, GCP, and Azure flag combinations.

Bumps go.temporal.io/cloud-sdk to v0.15.0 (and Go 1.26.4), which regenerates the cloud service mock and updates a protoutils golden fixture for new projectAccesses fields.

Reviewed by Cursor Bugbot for commit 96b608d. Bugbot is set up for automated code reviews on this repo. Configure here.

@david049 david049 requested a review from a team as a code owner July 7, 2026 19:10
Comment thread temporalcloudcli/commands.connectivity.go

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.

Fix All in Cursor

Reviewed by Cursor Bugbot for commit 8d61548. Configure here.

Comment thread temporalcloudcli/commands.connectivity_test.go
khisakuni
khisakuni previously approved these changes Jul 7, 2026

@khisakuni khisakuni left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a test that asserts that the connection ID is required, but otherwise LGTM!

@david049 david049 merged commit a54e910 into main Jul 8, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants