Add connectivity rule support for azure#91
Merged
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 8d61548. Configure here.
khisakuni
previously approved these changes
Jul 7, 2026
khisakuni
left a comment
Collaborator
There was a problem hiding this comment.
Looks like there's a test that asserts that the connection ID is required, but otherwise LGTM!
anekkanti
approved these changes
Jul 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What was changed
adds connectivity rule support for azure, bumps to latest sdk
Why?
Checklist
Closes
How was this tested:
local tested
3. Any docs updates needed?
Note
Medium Risk
Touches cloud connectivity creation paths and a major SDK bump with broad mock/API surface changes; misconfigured Azure/AWS/GCP flags could create invalid rules, but scope is limited to CLI connectivity commands.
Overview
Adds Azure private connectivity to
temporal cloud connectivity private createvia a new--azure-pe-resource-idflag, and passes that ARM resource ID through toPrivateConnectivityRulewhen creating rules.Private create is no longer AWS-only:
--connection-idis optional (still used for AWS/GCP), while--regionremains required. Help text andcommands.ymlnow document AWS, GCP, and Azure flag combinations.Bumps
go.temporal.io/cloud-sdkto v0.15.0 (and Go 1.26.4), which regenerates the cloud service mock and updates a protoutils golden fixture for newprojectAccessesfields.Reviewed by Cursor Bugbot for commit 96b608d. Bugbot is set up for automated code reviews on this repo. Configure here.