Emit Python variants as tagged case classes - #136
Draft
VegetarianOrc wants to merge 3 commits into
Draft
Conversation
VegetarianOrc
commented
Aug 21, 2026
| raise ValueError("missing required field GenericResponse.context") | ||
| if "completion" not in value: | ||
| raise ValueError("missing required field GenericResponse.completion") | ||
| (_context_t_type, _output_t_type, _metadata_t_type) = typing.get_args(type_hint) |
Contributor
Author
There was a problem hiding this comment.
These are used??? lol
Keep non-protobuf variants as tagged tuples and generate protobuf oneof cases as tag-free dataclasses. Dispatch protobuf conversion by case class identity without registering default variant transfer converters.
Keep oneof discovery, case naming, and dataclass rendering in the protobuf-specific Python module. Expose a generic variant block integration point from the main Python generator.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Breaking change
Validation
./scripts/validate.sh