feat: report PHP SDK identity in worker heartbeats via sdk-go SdkName option - #791
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d5c214d643
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
xepozz
force-pushed
the
feature/heartbeat-sdk-name-option
branch
from
July 31, 2026 14:05
d5c214d to
3aadd2b
Compare
Set ClientOptions.SdkName/SdkVersion (new in go-sdk) so worker heartbeats report temporal-php. Requires a go.temporal.io/sdk release that adds the option. Signed-off-by: Dmitriy Derepko <xepozz@list.ru>
xepozz
force-pushed
the
feature/heartbeat-sdk-name-option
branch
from
July 31, 2026 14:09
3aadd2b to
4b8555d
Compare
xepozz
changed the title
xepozz
marked this pull request as draft
July 31, 2026 14:11
xepozz
marked this pull request as ready for review
July 31, 2026 15:28
xepozz
marked this pull request as draft
July 31, 2026 15:28
Required for ClientOptions.SdkName/SdkVersion used by the worker heartbeat identity change. Signed-off-by: Dmitriy Derepko <xepozz@list.ru>
…dk-name-option Signed-off-by: Dmitriy Derepko <xepozz@list.ru> # Conflicts: # go.mod # go.sum # tests/go.mod
xepozz
marked this pull request as ready for review
August 19, 2026 18:46
rustatian
added
the
C-enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report the PHP SDK in worker heartbeats by setting the new
ClientOptions.SdkName/SdkVersion(added in go-sdk), instead of rewriting the heartbeat body in a gRPC interceptor.Depends on a
go.temporal.io/sdkrelease that exposes those options:temporalio/sdk-go@main...xepozz:temporal-sdk-go:feature/worker-heartbeat-sdk-name-override
Until that lands,
go.modis intentionally not bumped, so CI stays red.Wait temporalio/sdk-go#2511 to be merged
temporalio/sdk-php#720