Rejecting the blank task queue names in WorkerFactory.newWorker() - #3031
Open
ad-kat wants to merge 1 commit into
Open
Rejecting the blank task queue names in WorkerFactory.newWorker()#3031ad-kat wants to merge 1 commit into
ad-kat wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Closes
How was this tested:
What was changed
WorkerFactory.newWorker()will now reject blank/whitespace-only task queue names (e.g." ") in addition to null and empty strings. The error message was updated from "should not be an empty string" to "should not be an empty or blank string" to reflect this. A new test classWorkerFactoryValidationTestcovers null, empty, and blank task queue rejection usingTestWorkflowEnvironment.Why?
Strings.isNullOrEmpty(" ")returns false, so whitespace-only task queue names silently passed validation and were forwarded to the Temporal server, producing a cryptic server-side error instead of a clear, earlyIllegalArgumentExceptionat the call site.This aligns
WorkerFactorywith the validation pattern already used elsewhere in this codebase.StartNexusOperationOptions.setId()usestrim().isEmpty()for the same reason.Checklist
WorkerFactoryValidationTestwith three unit tests covering null, empty, and blank task queue names. All pass locally usingTestWorkflowEnvironment(no external service required).