Plumb DNS load-balancing options through to core#433
Open
GregoryTravis wants to merge 4 commits into
Open
Conversation
chris-olszewski
approved these changes
May 13, 2026
Member
chris-olszewski
left a comment
chris-olszewski
left a comment
There was a problem hiding this comment.
Looks good, super minor comment about type narrowing vs ignoring the error
| ) | ||
| stored = client.connection.options.dns_load_balancing | ||
| assert_equal dns_opts, stored | ||
| assert_in_delta 5.0, stored.resolution_interval # steep:ignore |
Member
There was a problem hiding this comment.
If possible try to avoid ignoring type errors and instead explicitly narrow
Suggested change
| assert_in_delta 5.0, stored.resolution_interval # steep:ignore | |
| raise 'stored is nil' if stored.nil? | |
| assert_in_delta 5.0, stored.resolution_interval # steep:ignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defaults load balancing to off.