Repository navigation
Restore Replication Foundation CODEOWNERS coverage - #238
Draft
michaely520 wants to merge 1 commit into
Draft
michaely520 wants to merge 1 commit into
michaely520 wants to merge 1 commit into
Conversation
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Add
@temporalio/replication-foundationalongside every existing CGS owner in.github/CODEOWNERS(1 rules). All existing owners and path precedence are preserved.Why?
The CGS team split and HR/Okta team sync removed Replication Foundation members from CGS. This restores the same code review coverage through the designated GitHub team.
How did you test it?
Verified the GitHub team exists; checked every affected rule and asserted that removing only the added team reproduces the original file byte for byte. No application code changed.
Potential risks
The team must have write access to this repository for GitHub to recognize it as a code owner. Repository grants and the missing Engineering parent relationship are tracked separately; this PR does not grant access. Keep this draft until the access prerequisite is verified.