refactor: use github-sts for Slack config token rotation - #79
Merged
Conversation
|
The latest Tipbot preview deployment for 00eddcc
|
Shut Down
sds
added a commit
that referenced
this pull request
Aug 21, 2026
#81) Adds `repo:tempoxyz@211589300/tip.bot@1232143975:environment:production` to the `slack-config` trust policy, the production counterpart to #80: the `update_slack_app` job runs in `environment: production`, so its OIDC subject is the environment form and the existing `refs/heads/main` subject does not match it. Without this, the production Slack app update would fail to mint once #79 lands. Also rewrites the subject comment to reflect that all rotating jobs run in environments; the ref/event subjects remain for any future job that rotates without one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switches
setup-slack-config-tokenfrom theSLACK_GH_TOKENfine-grained PAT to a short-lived token minted through github-sts viatempoxyz/gh-actions/actions/github-sts, authorized by theslack-configtrust policy added in #77.github-tokeninput and gainid-token: write.SLACK_GH_TOKENplumbing is removed frompull_request.ymland thepreview_deploy.ymlworkflow_callcontract.secrets: write, and the STS action revokes it when the job completes.After merge, the
SLACK_GH_TOKENrepository secret can be deleted and the PAT revoked.