fix: restrict secret workflows to org members - #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
workflow_runonly after checks passtempoxyzmember before preview deploy/destroy, external sweep requests, or production jobs can reach secretspull_request_targetand never check out PR coderepository_dispatch; remove unused dispatch triggers from check/zizmormembers: readfor the four trusted workflows onmainmainFinding
The PR preview gate trusted
author_association, admittedCOLLABORATOR, and checked the PR author rather than the actor who pushed the current SHA or reran the workflow. A non-org collaborator could therefore cause repository code to execute with preview deployment, fee-payer, Slack, and application secrets.preview_destroy, preview sweep requests, and production also reached secrets without validating the effective triggering actor.Verification
All PR checks pass:
Local supplemental checks:
zizmorreported no findings;actionlintfound no new warnings; the siblinggithub-stspolicy parser suite passed 52/52.