You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Bonus sub-tasks unreachable on rotation chores with daily_limit=1 (#365, #370)
For chores using alternating or random assignment with daily_limit=1 and one or more bonus sub-tasks, completing the parent chore caused the whole card — including any pending bonus sub-tasks — to disappear from the child card before the bonus sub-tasks could be ticked off.
Root cause: the parent completion filled the rotation pool's daily quota, so the backend _is_rotation_done_today returned True and stripped the chore from the active child's assigned_chores. Bonus sub-tasks render inside the parent card, so they vanished with it.
v3.9.3 (PR #366) addressed one client-side filter, but the backend strip path and a mirroring client filter were still affected. v3.9.4 completes the fix on both sides:
Backend (coord_assignments._is_rotation_done_today): bonus completions no longer count toward the parent quota, and the function keeps the chore visible while the active child still has uncompleted bonus sub-tasks for today.
Frontend (taskmate-child-card.js): the rotation-pool visibility filter mirrors the same guard so the client agrees with the backend.
Regression test added in tests/test_assignment_modes.py covering parent-done/bonus-pending, parent+bonus done, and the no-bonus baseline.
everyone-mode chores were never affected by this path. Rotation chores without bonus sub-tasks continue to hide as soon as the daily quota is met (existing behaviour preserved).
After the restart, configure a rotation chore (alternating or random) with Daily Completion Limit = 1 and add a bonus sub-task. Complete the parent — the card should stay visible. Tick the bonus sub-task — only then should the card hide.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
Uh oh!
There was an error while loading. Please reload this page.
-
🚀 New Release: v3.9.4
Fixed
Bonus sub-tasks unreachable on rotation chores with
daily_limit=1(#365, #370)For chores using
alternatingorrandomassignment withdaily_limit=1and one or more bonus sub-tasks, completing the parent chore caused the whole card — including any pending bonus sub-tasks — to disappear from the child card before the bonus sub-tasks could be ticked off.Root cause: the parent completion filled the rotation pool's daily quota, so the backend
_is_rotation_done_todayreturnedTrueand stripped the chore from the active child'sassigned_chores. Bonus sub-tasks render inside the parent card, so they vanished with it.v3.9.3 (PR #366) addressed one client-side filter, but the backend strip path and a mirroring client filter were still affected. v3.9.4 completes the fix on both sides:
coord_assignments._is_rotation_done_today): bonus completions no longer count toward the parent quota, and the function keeps the chore visible while the active child still has uncompleted bonus sub-tasks for today.taskmate-child-card.js): the rotation-pool visibility filter mirrors the same guard so the client agrees with the backend.Regression test added in
tests/test_assignment_modes.pycovering parent-done/bonus-pending, parent+bonus done, and the no-bonus baseline.everyone-mode chores were never affected by this path. Rotation chores without bonus sub-tasks continue to hide as soon as the daily quota is met (existing behaviour preserved).How to update
HACS → TaskMate → ⋮ → Redownload → pick
v3.9.4→ restart Home Assistant.After the restart, configure a rotation chore (alternating or random) with
Daily Completion Limit = 1and add a bonus sub-task. Complete the parent — the card should stay visible. Tick the bonus sub-task — only then should the card hide.Full changelog: v3.9.3...v3.9.4
Upgrading
Update via HACS or by downloading the latest release and copying to
/config/custom_components/taskmate/.After updating, restart Home Assistant. Lovelace resources will update automatically on restart.
💬 Questions or issues with this release? Reply below or open an issue.
Beta Was this translation helpful? Give feedback.
All reactions