fix(ssr): extract page-specific Astro CSS - #285
Merged
Conversation
Contributor
📦 Snapshot releasePublished |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base,build.assets, and string/CSS-specific/fallbackbuild.assetsPrefixvaluesurl()values whose targets would change after external extractionFully shared pages omit an empty page asset; pages with no common artifacts receive only their page asset. The shared-base/page-override order is the extraction-mode cascade contract.
Verification
pnpm typecheckpnpm lintpnpm format/pnpm format:checkpnpm buildpnpm sizepnpm test(82 files, 2,180 tests)pnpm check:test-onlypnpm knipTested in a disposable build of
tenphi.mewith the branch linked locally: