Repository navigation
test: count multi-worker allocation windows at steady state (#321) - #322
Merged
Merged
Conversation
The process-wide counters in the strided-basic, strided-fused and strided-kernel allocation tests failed intermittently on macOS (1-2 allocations). A pool worker that the warm-up never scheduled pays one-time first-touch costs (thread-local registration allocates on macOS) when it first picks up a split. Each multi-worker window now runs three times and reports the minimum. A per-call allocation still shows up in every round, so the steady-state contract is unchanged. Closes #321. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Repository rules reviewRepository rules review (13f8165ade2e15db24526069df1ac971687beb67...9d80d567feba1f2a0af5b80a74fd8276d2359199) Verdict: pass Findings: - [warn] llm-skipped (External LLM Review) <unknown>: External LLM review was skipped External LLM review is permanently disabled; deterministic checks only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #321.
The process-wide allocation counters in
strided-basic/tests/alloc_matrix.rs,strided-fused/tests/serial_specialization_alloc.rsandstrided-kernel/tests/copy_plan_alloc.rsfailed intermittently on macOS. Two failures were seen on #320, a version-only PR: the fused two-worker replay allocated 1, and thezip_reducecontiguous two-worker window allocated 2.Cause: a pool worker that the single warm-up never scheduled pays one-time first-touch costs the first time it picks up a split. Thread-local registration allocates on macOS. This is not a per-call allocation.
Fix: each multi-worker window runs three times and reports the minimum. A per-call allocation shows up in every round, so the steady-state zero contract is unchanged. Thread-local (serial) windows are untouched.
Local: the three tests pass, with and without
parallel.🤖 Generated with Claude Code