Repository navigation
Report S2 timing ratio while retaining allocation gate - #356
Merged
Merged
Conversation
Repository rules reviewRepository rules review (91185c8d0498b50739507a9c49b6cf247186ac7b...23a7d10bca855f947f38a43e1b5806f5e8faf981) Verdict: pass Findings: - [warn] llm-skipped (External LLM Review) <unknown>: External LLM review was skipped External LLM review is permanently disabled; deterministic checks only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refs #355.
Local validation
OVERHEAD_GATE=1 taskset -c 0-7 cargo test -j 4 -p strided-fused --benches: passed; S2 reported with zero allocations.OVERHEAD_GATE=1 taskset -c 0-7 cargo test -j 4 -p strided-fused --bench overhead_smokesucceeded with S2 ratio 1.118 andreport (ref 0.01; alloc=0); restored 1.5 afterward.cargo test -j 4 --workspace, parallel-feature tests for basic/kernel/fused, both release overhead smoke gates,cargo doc --workspace --no-deps, formatting and repository-rules review passed.cargo clippy -j 4 -p strided-fused --all-targets --no-depspassed with existing warnings. Workspace-wide clippy on rustc 1.99 fails on the existingclippy::uninit_vecatstrided-view/src/view.rs:1440; workspace-D warningsalso stops at existingclippy::suspicious_arithmetic_implinstrided-traits/src/scalar.rs:71. Neither is a CI clippy gate in this repository.The old fused bench header said a gate fails only after all timing attempts exceed the threshold; the existing allocation check was an additional failure condition. The header now states both.