fixed _profile#13
Open
pnthrr wants to merge 2 commits intotermermc:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#12 the issue was that profileRoot on line 18:
const profileRoot = makeFileUrl(fsUrl, uuid, username, '/_profile')is a full URL returned by
makeFileUrlbut resolved is only the.pathnameof a url resolved againstwindow.location.originthus a pathname like/image.pngcan never start with a full url from a different origin.so you have to resolve the
pathagainstindexUrland compare.pathnameofprofileRoot.Note: might have used the code highlight thing a bit too much, and yapped too.
another note: this whole check is kinda of lacking and has a lot of issues i would suggest either removing it or doing a lot of fixing