fix(sandbox): allow kube-dns ClusterIP in sandbox DNS egress - #378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sandbox pods on GKE could not resolve any hostname: the DNS egress rule only matched the kube-system namespaceSelector, but lookups go to the kube-dns ClusterIP, which Dataplane V2 only admits via an ipBlock.
The control-plane pod now reads its own /etc/resolv.conf and appends each nameserver as a /32 ipBlock to the DNS rule — per-cluster correct with no new config, and degrades to the old behaviour if resolv.conf is unreadable.
Verified: unit suite green (2063 passed); regression tests cover both the ipBlock and the missing-resolv.conf fallback.