fix(sandbox): grant the egress proxy web-port internet access - #379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sandbox fence policy selects every pod carrying the sandbox label — including the egress proxy — so the proxy could enforce its allowlist but never reach the allowed domains: every proxied request to pypi/github timed out while direct internet stayed (correctly) blocked.
This adds a second, additive NetworkPolicy scoped to the proxy pod only, opening TCP 443/80 to 0.0.0.0/0 with the RFC1918 and link-local ranges excluded, so the proxy cannot be used to pivot into the VPC or cluster. The runner still has no direct route out; its only path remains the allowlisting proxy.
Verified live before the fix: in-sandbox probe showed example.com rejected 403 by the proxy (allowlist works) but pypi.org timing out through it. Unit suite green (2064 passed) with a regression test on the new policy shape.