fix(auth): harden logout against cross-site CSRF - #380
Merged
Conversation
GET logout stays for browser navigation, but Sec-Fetch-Site: cross-site requests (hostile img/script tags) can no longer force-clear sessions.
Fetch metadata is authoritative when present; otherwise a mismatched or opaque Origin is rejected. Covers hostile img tags, auto-submitted cross-site forms, and sandboxed-iframe null origins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebases the two unmerged commits from fix/auth-logout-get onto current main: cross-site GET logout requests (hostile img/script tags) are rejected via Sec-Fetch-Site, and the guard extends to POST, legacy cross-origin clients, and sandboxed-iframe null origins.
The test conflict with the newer auto-login suite is resolved by keeping both: TestLogout_RejectsCrossSiteRequests covers eight navigation/origin cases, and the auto-login tests are unchanged. go build/vet/test all green.