fix(AppShell): wire up <nullable/> control hint - #2149
Merged
Conversation
alexwarren
force-pushed
the
fix/editor-nullable-control-hint
branch
2 times, most recently
from
August 26, 2026 16:59
1530324 to
544700e
Compare
<nullable/> was fully dead - a field could be edited freely but never fully unset back to inherited/default; overwriting it with an empty string still counts as an explicit override (WorldModel attribute inheritance treats "unset" and "" differently). Matches the old Quest 5 desktop editor's TextBoxControl/RichTextControl/ ExpressionControl: emptying a nullable field's value saves null (removing the attribute) instead of "". No separate UI affordance is needed or correct - an earlier version of this fix added a per-row "clear" button, but that rendered in the wrong place for any stacked (multiline, or long-label) field, since the button and the field it targeted ended up as separate flex items in the stacked layout, and it also didn't stop the field's own onchange from saving "" first when the button wasn't used. Wired through onTextChange/onDropdownChange for textbox, richtext, expression, and freetext dropdown - the only control types Core.aslx actually pairs with <nullable/>. Part of #2116. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
alexwarren
force-pushed
the
fix/editor-nullable-control-hint
branch
from
August 26, 2026 17:02
544700e to
b9b3043
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<nullable/>was fully dead (29 uses across 8.aslxfiles, e.g. an exit's Alias/Type dropdowns, severalCoreEditorObjectContainer.aslxtextboxes) - there was no way to fully unset a nullable field's attribute back to inherited/default from the property panel; only to overwrite it with an empty string, which is a different state (WorldModel attribute inheritance distinguishes "unset" from"").RemoveAttributealready existed on the WASM bridge (WasmEditorBridge.cs:3210) and was already exposed to the frontend asremoveAttribute(editor-store.ts), used byAttributesEditor.svelte's attribute-table delete button - it just wasn't offered anywhere on a regular property-panel control row.<nullable/>throughToControlInfo/ControlInfoand adds a small "✕" clear button next to any nullable control that currently has an explicit value (hidden once cleared), which calls the existingremoveAttributeinstead ofsetAttribute(attribute, "").Test plan
dotnet build --configuration Releasedotnet test --configuration Release(all passing)npm run check/npm run lintinsrc/AppShell(clean)node tests/e2e/find-affected-tests.mjs+ ran the relevant flagged scripts (verify-appshell-exits-editor, verify-appshell-attributes-panel-pinned, verify-appshell-code-view) against a local dev server - all pass.<exit />has noaliasattribute at all afterward (not evenalias="") - i.e. it reverted to truly unset, not just blank.🤖 Generated with Claude Code