fix(AppShell): wire up <bold/> control hint for labels - #2154
Open
alexwarren wants to merge 1 commit into
Open
Conversation
<bold/> was fully dead (2 uses) - a "label" control's caption always
rendered in normal weight regardless of the tag, e.g. an exit's "to unlock
this exit... you must give it a name below" warning-style note.
Threads ctrl.GetBool("bold") through ToControlInfo into a font-semibold
class on both label rendering branches (plain text and href link) in
PropertyEditor.svelte.
Part of #2116.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<bold/>was fully dead (2 uses: an exit's "to unlock this exit..." warning-style note inCoreEditorExit.aslx:50, and a container's disabled-feature notice inCoreEditorObjectContainer.aslx:20) - a"label"control's caption always rendered in normal weight regardless of the tag.ctrl.GetBool("bold")throughToControlInfointo a conditionalfont-semiboldclass on both label rendering branches (plain text andhreflink) inPropertyEditor.svelte.Test plan
dotnet build --configuration Releasedotnet test --configuration Release(all passing)npm run check/npm run lintinsrc/AppShell(clean)node tests/e2e/find-affected-tests.mjs+ ran verify-appshell-exits-editor against a local dev server - passes.font-weight: 600(previously 400).🤖 Generated with Claude Code