Skip to content

fix(AppShell): wire up <bold/> control hint for labels - #2154

Open
alexwarren wants to merge 1 commit into
mainfrom
fix/editor-bold-label-hint
Open

fix(AppShell): wire up <bold/> control hint for labels#2154
alexwarren wants to merge 1 commit into
mainfrom
fix/editor-bold-label-hint

Conversation

@alexwarren

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • dotnet build --configuration Release
  • dotnet test --configuration Release (all passing)
  • npm run check / npm run lint in src/AppShell (clean)
  • node tests/e2e/find-affected-tests.mjs + ran verify-appshell-exits-editor against a local dev server - passes.
  • Manual check in-browser: checked an exit's "Locked" box (with no name set) to surface the "To unlock this exit during the game or to change its visibility using a script, you must give it a name below." label, and confirmed via computed style that it now renders with font-weight: 600 (previously 400).

🤖 Generated with Claude Code

<bold/> was fully dead (2 uses) - a "label" control's caption always
rendered in normal weight regardless of the tag, e.g. an exit's "to unlock
this exit... you must give it a name below" warning-style note.

Threads ctrl.GetBool("bold") through ToControlInfo into a font-semibold
class on both label rendering branches (plain text and href link) in
PropertyEditor.svelte.

Part of #2116.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant