Repository navigation
Add sitemap, fix canonical domain, add Person structured data - #8
Merged
Merged
Conversation
Search engines had no index of the site's routes and no way to connect the off-site profiles to their owner. - Add a prerendered /sitemap.xml endpoint listing the homepage and /resume. Routes live in one array so adding a page is a one-line change. - Point robots.txt at the sitemap. - Correct the canonical domain from taehoonlee.dev to thdxg.dev in the Open Graph URL, Open Graph image, and Twitter image meta tags. - Add Person JSON-LD to the app shell. A sitemap may only list URLs on its own host, so sameAs is what actually declares the GitHub and LinkedIn profiles as the same person.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/sitemap.xml— a prerendered SvelteKit endpoint listing the homepage and/resume, served with a one-hour cache header. The page list is a single array at the top of the file, so adding a route is a one-line change.robots.txtnow advertises the sitemap via aSitemap:line.taehoonlee.devtothdxg.devin the Open Graph URL, Open Graph image, and Twitter image meta tags.PersonJSON-LD added to the app shell, declaring the GitHub and LinkedIn profiles as belonging to the same person.Why
The site had no sitemap, so crawlers had to discover routes by following links. Separately, three meta tags still pointed at the old domain, which would have sent Open Graph and Twitter card scrapers to the wrong host for the preview image.
The structured data answers a related question that a sitemap cannot. The sitemaps protocol requires every
<loc>to share the sitemap's own host, and Google discards cross-domain entries, so external profile URLs have no valid place there. AsameAsarray on aPersonnode is the mechanism that actually associates those profiles with the site's owner.Notes for review
src/app.htmlrather than the homepage component. Every other SEO tag is already hardcoded there, and embedding it in Svelte markup requires a literal</script>inside an expression, which breaks both the Svelte compiler and the ESLint Svelte parser. The workaround needs{@html}plus asvelte/no-at-html-tagssuppression, which is not worth it for two URLs that rarely change.affiliationsince it is in progress, while Emory isalumniOf.Verification
svelte-checkpasses with 0 errors.bun run lintreports the same 2 pre-existing errors as the base branch, with none added.build/prerendered/sitemap.xml.