feat: support configurable Atlassian MCP server via ATLASSIAN_MCP_SERVER_URL and pass-through OAuth metadata - #546
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| if (!process.env.ATLASSIAN_MCP_SERVER_URL) { | ||
| console.error('ATLASSIAN_MCP_SERVER_URL environment variable is not set') | ||
| return [] | ||
| } | ||
|
|
||
| const serverParams = { | ||
| url: 'https://mcp.atlassian.com/v1/sse' | ||
| url: `${process.env.ATLASSIAN_MCP_SERVER_URL}/sse` |
There was a problem hiding this comment.
[P1] Env var can’t satisfy both MCP metadata and SSE URLs
The new configuration assumes a single ATLASSIAN_MCP_SERVER_URL is used for all Atlassian MCP endpoints, but the code now derives the SSE address as ${ATLASSIAN_MCP_SERVER_URL}/sse here while fetchMCPMetadata builds its OAuth well‑known URL as ${ATLASSIAN_MCP_SERVER_URL}/.well-known/oauth-authorization-server. On the current Atlassian service the SSE endpoint lives under /v1/sse while the metadata lives at /.well-known/..., so no single value for ATLASSIAN_MCP_SERVER_URL can make both requests correct. Setting it to the host breaks SSE (…/sse), and adding /v1 fixes SSE but causes metadata requests to …/v1/.well-known, which will 404. This effectively breaks existing installations unless a second variable or path handling is added.
Useful? React with 👍 / 👎.
ct3685
changed the title
ATLASSIAN_MCP_SERVER_URL and pass-through OAuth metadata
This commit introduces several updates to the configuration and functionality of the DALL-E image generation tools. ### Changes: - Added a new environment variable `API_HOST` to the manifest for better API endpoint management. - Updated the `next.config.js` to support HTTPS for the specified hostname. - Modified the DALL-E image tools to prioritize the new `API_HOST` variable for constructing URLs, ensuring that the tools can correctly reference the API in production environments. - Incremented the version of the DALL-E tools from 1.0 to 1.1 to reflect these changes. ### Impact: These updates enhance the flexibility of the API configuration and improve the reliability of image generation by ensuring the correct API endpoint is used based on the environment settings.
## Summary Updates to webinar landing pages, ElevenLabs widget integration, and supporting styles. ## Changes - Enhanced ElevenLabs inline widget component with improved functionality and styles - Updated webinar enterprise AI landing page with improved content structure - Refactored webinar thank you page layout and user experience - Streamlined mailerLite service implementation - Improved responsive design for index page with additional styles ## Test plan - [x] Tested webinar landing page locally - [x] Verified ElevenLabs widget integration works correctly - [x] Confirmed thank you page displays properly after registration - [x] Validated responsive design on mobile and desktop - [x] ESLint and prettier checks pass
Render
Inactive
3 participants
Title
feat: support configurable Atlassian MCP server via
ATLASSIAN_MCP_SERVER_URLand pass-through OAuth metadataDescription
Motivation
Enable use of a custom remote MCP server instead of the hard-coded Atlassian endpoint. Ensure all OAuth flows and SSE connectivity respect a configurable base URL. Motivation not evident from diff beyond enabling configurability.
Enhancements
${process.env.ATLASSIAN_MCP_SERVER_URL}/sse.ATLASSIAN_MCP_SERVER_URLis missing.ATLASSIAN_MCP_SERVER_URL; return an auth error if unset.fetchMCPMetadata(baseUrl)instead of defaulting./api/v1/atlassian-auth/mcp-initializetoWHITELIST_URLS.registerOAuthClient: requireATLASSIAN_MCP_SERVER_URL; pass it tofetchMCPMetadata..join(' ')to a single consolidated space-delimited string including Jira and Confluence read/write scopes plusoffline-access,read:me, andread:account.refreshStoredCredentialTokens: requireATLASSIAN_MCP_SERVER_URL; pass it tofetchMCPMetadatabefore refreshing tokens.fetchMCPMetadatasignature to require an explicitbaseUrl; remove default'https://mcp.atlassian.com'.Expected Impact
ATLASSIAN_MCP_SERVER_URL, enabling self-hosted or environment-specific deployments.Breaking Changes
ATLASSIAN_MCP_SERVER_URLmust be set for:fetchMCPMetadatanow requires abaseUrlargument; callers updated accordingly. Any external/internal callers not updated will break at compile/runtime.Config / Env Changes
ATLASSIAN_MCP_SERVER_URL(e.g.,https://my-mcp.example.com).Routes / Security
WHITELIST_URLSincludes/api/v1/atlassian-auth/mcp-initializeto support the auth/init flow. Ensure this is intended and reviewed.