Skip to content

Release: Critical Billing Fix - 2025.10.24 #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxtechera merged 1 commit into from
Oct 24, 2025
Merged

Release: Critical Billing Fix - 2025.10.24 #641

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion packages/server/src/aai-utils/billing/langfuse/LangfuseProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ export class LangfuseProvider {
userId?: string
filter?: any[]
fields?: string
orderBy?: string
}): Promise<any> {
const queryParams: any = { ...params }

Expand Down Expand Up @@ -151,13 +152,21 @@ export class LangfuseProvider {
limit: 1,
page: 1,
filter: LangfuseProvider.UNPROCESSED_FILTER,
fields: 'core' // Minimal fields for discovery
fields: 'core', // Minimal fields for discovery
orderBy: 'timestamp' // CRITICAL: Order by timestamp ascending (default) to get OLDEST first
// Note: Langfuse API defaults to ascending order, so just 'timestamp' should work
// If this returns newest instead of oldest, we fall back to 2020-01-01 anyway
Comment on lines 152 to +158

@chatgpt-codex-connector chatgpt-codex-connector Bot Oct 24, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Oldest-trace lookup still sorts newest first

The fix adds orderBy: 'timestamp' to findOldestUnprocessedTrace() but does not change the sort direction that the Langfuse API applies. The API returns traces ordered by timestamp descending unless an ascending direction is sent (e.g., an order parameter or orderBy=timestamp,asc). Passing only the field name leaves the default direction intact, so the limit: 1 call still returns the newest unprocessed trace and the subsequent window loop begins near “now”, skipping historical traces exactly as before. To actually fetch the oldest trace, the request must explicitly specify ascending order.

Useful? React with 👍 / 👎.

})

if (response.data.length === 0) {
return null // No unprocessed traces
}

log.info('Found oldest unprocessed trace', {
traceId: response.data[0].id,
timestamp: response.data[0].timestamp
})

return new Date(response.data[0].timestamp)
} catch (error) {
log.warn('Failed to find oldest trace, defaulting to 2020-01-01', { error })
Expand Down
Loading