chore(release): staging to production - 2026.01.19

[github-actions]

🚀 Release: Staging to Production

Release Date: 2026-01-19

Changes in this release

• fix(AGENT-630): backup all user-referenced orgs to preserve Auth0 alignment (f7f6fdf)
• fix(AGENT-630): fix orphaned users' organizationId before workspace creation (f4a6a29)
• fix(AGENT-630): handle invalid organizationId in AAI migration (20e3e0e)
• feat(SUPPORT-9): add edit and delete credential features to Fiddler guardrails (0565fc7)
• fix(SUPPORT-8): force Organization visibility for Fiddler credentials (61bd5b7)

---

This PR is automatically created/updated when commits are pushed to staging.
Merging this PR will trigger the release workflow to create a new GitHub release.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
answerai-docs	Building	Preview	Jan 14, 2026 7:59pm
the-answerai	Building	Preview	Jan 14, 2026 7:59pm

[claude]

🔍 PR Review: Fiddler Guardrails Credential Management

📋 Summary

This release PR merges two features to staging → production:

1. SUPPORT-8: Force Organization visibility for Fiddler credentials
2. SUPPORT-9: Add edit/delete credential features to Fiddler guardrails UI

✅ Strengths

1. Multi-tenancy Alignment

• ✅ Migration properly updates existing credentials to Organization visibility
• ✅ defaultVisibility prop enforces org-wide credentials at UI level
• ✅ Aligns with repository's multi-tenancy requirements (CLAUDE.md)

2. User Experience Improvements

• ✅ Auto-enable guardrails when creating/selecting credentials (lines 116-118, 339-340)
• ✅ Confirmation dialog for delete operations prevents accidental deletions
• ✅ Snackbar notifications provide clear feedback for success/error states
• ✅ Buttons disabled when guardrails toggle is OFF - clear visual feedback

3. Code Quality

• ✅ Proper error handling with detailed error messages
• ✅ Consistent use of Material-UI patterns
• ✅ Clean separation of concerns (handlers for create/edit/delete)
• ✅ Migration includes both up and down methods for rollback capability

4. Migration Best Practices

• ✅ Conditional update (only changes Private → Organization)
• ✅ Filters by credentialName = 'fiddlerApi' to avoid affecting other credentials
• ✅ Clear comments explaining intent

🔴 Critical Issues

1. Race Condition in loadCredentials (Line 62)

setLoadingCredentials(false)  // Line 62 - WRONG
const response = await credentialsApi.getCredentialsByName('fiddlerApi')
setCredentials(response.data || [])

Issue: Sets loadingCredentials to false BEFORE the async operation starts.
Fix: Should be:

setLoadingCredentials(true)  // Start loading
const response = await credentialsApi.getCredentialsByName('fiddlerApi')
setCredentials(response.data || [])

2. Missing Error Handling

• Line 104: handleCreateCredential catches error but only logs to console - no user feedback
• Line 127: handleEditCredential has NO error handling - credential load failure is silent
• Recommendation: Add snackbar error notifications similar to delete handler (lines 168-183)

⚠️ High Priority Issues

3. Test Coverage Gap

The existing E2E test file (guardrails-settings.spec.ts) does NOT cover:

• ❌ Credential creation flow
• ❌ Edit credential functionality
• ❌ Delete credential with confirmation
• ❌ Organization visibility enforcement
• ❌ Auto-enable behavior on credential selection

Recommendation: Add test cases for the new CRUD operations:

test('Can create new Fiddler credential with Organization visibility', async ({ page }) => {
  // Test credential creation modal
  // Verify defaultVisibility is set to Organization
})

test('Can edit existing credential', async ({ page }) => {
  // Test edit button opens dialog in EDIT mode
})

test('Delete credential shows confirmation and removes credential', async ({ page }) => {
  // Test delete confirmation dialog
  // Verify credential is removed after confirmation
})

4. Security: SQL Injection Prevention

-- Line 10-15 (Migration)
UPDATE "credential"
SET "visibility" = 'Organization'
WHERE "credentialName" = 'fiddlerApi'
AND "visibility" = 'Private'

✅ Good: Uses parameterized string literals (no interpolation)
✅ Good: TypeORM's queryRunner.query handles escaping

However:
⚠️ Caution: No validation that fiddlerApi string is hardcoded constant
Recommendation: Define as constant:

const FIDDLER_CREDENTIAL_NAME = 'fiddlerApi' as const

🟡 Medium Priority Issues

5. Type Safety Concerns

const handleCredentialDialogConfirm = (credentialId: string) => {
    // ...
    if (credentialId && credentialDialogProps.type === 'ADD') {

Issue: credentialDialogProps is typed as any (line 40)
Recommendation: Define proper interface:

interface CredentialDialogProps {
    type: 'ADD' | 'EDIT'
    cancelButtonName: string
    confirmButtonName: string
    credentialComponent?: any
    data?: Credential
    defaultVisibility?: string[]
}

6. Accessibility

• ⚠️ Delete button is color='error' but no aria-label explaining destructive action
• ⚠️ Edit/Delete buttons disabled state should have aria-disabled explanation
  Recommendation: Add aria labels:

<Button
    aria-label="Delete Fiddler credential (requires guardrails enabled)"
    disabled={!enabled}
    // ...
>

7. Performance: Unnecessary Re-renders

Line 45-47 creates new function instances on every render:

const enqueueSnackbar = (...args: any[]) => dispatch(enqueueSnackbarAction(...args))
const closeSnackbar = (...args: any[]) => dispatch(closeSnackbarAction(...args))

Recommendation: Use useCallback:

const enqueueSnackbar = useCallback((...args: any[]) => 
    dispatch(enqueueSnackbarAction(...args)), [dispatch])

🟢 Minor Issues

8. Code Style

• Line 188: selectedCredentialObj is computed but could be memoized with useMemo for optimization
• Inconsistent spacing in button groups (lines 261-290 vs 299-312)

9. Documentation

• Migration file has excellent inline comments ✅
• Component handlers lack JSDoc comments explaining side effects

🎯 Recommendations Summary

Priority	Action	Effort
🔴 CRITICAL	Fix loadCredentials race condition (line 62)	5 min
🔴 CRITICAL	Add error handling to handleCreateCredential and handleEditCredential	15 min
⚠️ HIGH	Add E2E tests for CRUD operations	2-3 hours
⚠️ HIGH	Extract credential name as constant	5 min
🟡 MEDIUM	Add proper TypeScript interfaces	20 min
🟡 MEDIUM	Improve accessibility with aria-labels	15 min
🟡 MEDIUM	Optimize with useCallback	10 min

🚀 Deployment Considerations

Database Migration:

• ✅ Migration is safe to run in production (idempotent, conditional update)
• ✅ No data loss risk (only changes visibility field)
• ⚠️ Run during low-traffic window as precaution (affects credential table)

Rollback Plan:

• ✅ Migration includes down() method for rollback
• ⚠️ UI changes cannot be rolled back independently (requires redeployment)

📊 Overall Assessment

Code Quality: 7.5/10
Security: 8/10
Test Coverage: 4/10 (major gap)
User Experience: 9/10
Multi-tenancy Compliance: 10/10

✅ Approval Status

Recommendation: ⚠️ APPROVE WITH CONDITIONS

The features are well-implemented and align with repository standards. However:

1. MUST FIX the loadCredentials race condition before merge (critical bug)
2. SHOULD ADD error handling for credential operations
3. SHOULD ADD E2E test coverage in follow-up ticket

---

Great work on the UX improvements! The auto-enable behavior and confirmation dialogs significantly improve the user experience. The migration is well-structured and safe. Main concerns are the race condition bug and missing test coverage.

Review completed by Claude Code following CLAUDE.md standards

[claude]

Pull Request Review - Release: Staging to Production

Summary

This PR includes 5 commits addressing critical data integrity issues (AGENT-630) and Fiddler guardrails enhancements (SUPPORT-8, SUPPORT-9).

CRITICAL ISSUE Found

Location: packages-answers/ui/src/GuardrailsSettings/MasterConfig.tsx:62

Bug: Loading state is set to FALSE before the async operation starts. The loading spinner will never show.

Fix Required: Change line 62 from setLoadingCredentials(false) to setLoadingCredentials(true)

Medium Priority Issues

1. Missing Error Handling - handleCreateCredential (line 84-106) catches errors but shows no user feedback
2. SQL Injection Risk - BackupAAIData migration uses string interpolation instead of parameterized queries
3. Migration Ordering - UpdateFiddlerCredentialsVisibility runs late but modifies existing credentials

Code Quality

1. Type Safety - Line 40 uses any type for credentialDialogProps
2. Duplicate Code - Snackbar close button appears 4 times
3. Performance - fixInvalidOrganizationIds has N+1 query problem

Testing Concerns

No E2E or unit tests added for new credential edit/delete functionality or migration rollback scenarios.

Security

Good: Confirmation dialogs, org-scoped visibility, error handling
Concerns: SQL interpolation, no audit trail, error messages may expose IDs

Overall Assessment

Recommendation: Approve with required changes

The PR addresses real data integrity issues but the loading state bug must be fixed before production.

Risk Level: Medium

• Migration logic is sound
• UI bug is cosmetic but noticeable
• Missing tests for delete functionality

Must Fix: Loading state bug (~10 min fix)
Should Address: Error handling, parameterized queries, tests (~2 hours)

---

Review completed by Claude Code