docs: add OpenCode bootstrap context validation - #967
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
PR Review: docs: add OpenCode bootstrap context validationPR: #967 | Author: @maxtechera | Base: staging SummaryThis PR establishes a parity layer between Claude Code and OpenCode by documenting which configuration files OpenCode should treat as first-class context, and providing a validation script to verify that all required bootstrap files and directories are present. The changes are entirely documentation and developer tooling — no production code, business logic, routes, database queries, or authentication is touched. Because this is a docs/tooling-only PR, the multi-tenancy (organizationId), authentication (enforceAbility), and component (tags: ['AAI']) checklists are not applicable here. Critical IssuesNone. There are no security vulnerabilities, data-handling issues, or breaking changes in this PR. Major Concerns1. Validation script will fail on a fresh clone Location: Several directories listed as "required" are gitignored or not guaranteed to exist in all environments:
More critically, Recommendation: Consider separating "required for the tool to function" from "required as context hints for OpenCode". Directories like 2. Location: process.exitCode = 1Using Minor Issues and Suggestions3. Location: The For a reader consulting only 4. Precedence order differs in capitalisation and phrasing between files Location: In In Minor capitalisation inconsistency. Keeping these identical reduces ambiguity for tooling that may parse the precedence rules. 5. Script lacks a shebang-friendly description / usage comment Location: Other scripts in this repo (e.g., /**
* OpenCode Bootstrap Validator
*
* Verifies that all files and directories required for OpenCode context
* bootstrap are present in the repository.
*
* Usage: node scripts/validate-opencode-bootstrap.js
* pnpm opencode:validate-context
*/6. Script output lacks ANSI colour for discoverability in terminals Location: Other validation scripts in this repo use ANSI colour codes to highlight PASS/FAIL/WARN states. For CI and local developer experience, coloured output makes the result immediately visible. This is a stylistic suggestion to match the existing script conventions. 7. Location: The new script is inserted after Positive Observations
TheAnswer-Specific Checklist
Next Steps
|
c0dbf4e to
cb995ec
Compare
PR Review: docs: add OpenCode bootstrap context validationPR: #967 | Author: @maxtechera | Base: SummaryThis is a pure documentation and developer-tooling PR. It makes two small changes:
No production code, business logic, API routes, database queries, authentication, or component logic is touched. The PR body references a validation script and Critical IssuesNone. There are no security vulnerabilities, no data-handling concerns, and no breaking changes. Major Concerns1. PR description is out of sync with the actual diff Location: PR body The PR summary describes three deliverables: a bootstrap section in This creates ambiguity for reviewers: it is unclear whether those items were intentionally dropped, are coming in a follow-up PR, or were accidentally left off the branch. Updating the PR description to match what is actually being merged would eliminate the confusion. 2. Location:
Minor Issues and Suggestions3. Index table row for Location: The current description is "Specialized agents (Linear, Git, Fleet)". There are now 24 agent files in 4. Index table does not acknowledge Location: The 5. Branch name prefix does not match commit type Location: Branch The commit message correctly uses Positive Observations
TheAnswer-Specific Checklist
Overall RecommendationComment — approve with minor suggestions The change is safe, additive, and addresses a real gap in developer-tooling parity between Claude Code and OpenCode. Two items are worth addressing before merge:
Neither is a hard blocker, but both would make the PR self-consistent and easier to understand in the git history. |
Summary
AGENTS.mdso Claude workflow docs/config are treated as first-class context.opencode/README.mddocumenting required config/docs directories and instruction precedencescripts/validate-opencode-bootstrap.jspluspnpm opencode:validate-contextto verify required bootstrap files/directories are present