Skip to content

Fix release tag pattern and drop redundant manual gem push #404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zjhuntin merged 1 commit into from
Aug 11, 2026
+2 −13
Merged

Fix release tag pattern and drop redundant manual gem push #404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ name: Release
on:
push:
tags:
- 'v*'
- '*'

jobs:
release:
Expand Down
13 changes: 1 addition & 12 deletions rel-eng/gem_release.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1349,9 +1349,7 @@
{
"cell_type": "markdown",
"metadata": {},
"source": [
"### Build the gem"
]
"source": "### Build the gem (local sanity check only)\n\nPublishing to rubygems.org is now handled automatically by the `Release` GitHub Actions\nworkflow, which triggers on tag push (see the final `git push --tags` step below) and\npublishes via rubygems.org trusted publishing. Do **not** `gem push` manually here — it\nwould either race with CI or fail because the version is already published."
},
{
"cell_type": "code",
Expand All @@ -1362,15 +1360,6 @@
"! rake build"
]
},
{
"cell_type": "code",
"execution_count": null,
"metadata": {},
"outputs": [],
"source": [
"! gem push pkg/hammer_cli-{NEW_VERSION}.gem"
]
},
{
"cell_type": "markdown",
"metadata": {},
Expand Down
Loading