Skip to content

Stabilize Windows modern compatibility package by auto-cloning missing codec sources#601

Merged
themuffinator merged 2 commits into
mainfrom
copilot/fix-windows-modern-compatibility-job
Jun 9, 2026
Merged

Stabilize Windows modern compatibility package by auto-cloning missing codec sources#601
themuffinator merged 2 commits into
mainfrom
copilot/fix-windows-modern-compatibility-job

Conversation

Copilot AI commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

ℹ️ Before filling this template, review the Contributor Checklist to confirm your harness runs, baselines, and syscall documentation are ready for review.

Summary

  • Linked issue or task: GitHub Actions failure in Windows modern compatibility package (job 80250207764)
  • Description of changes: The Windows nightly lane failed on clean runners because src/libs/_deps was missing and codec bootstrap required pre-populated sources. This change makes bootstrap self-healing by cloning missing codec trees before configure/build.
    • Root cause
      • tools/build_internal_deps.ps1 failed fast when libogg/libvorbis/zlib/libpng source trees were absent under src/libs/_deps.
    • Bootstrap fix
      • Replaced strict source-presence checks with Ensure-GitDependencySource for:
        • libogg (xiph/ogg, v1.3.5)
        • libvorbis (xiph/vorbis, v1.3.7)
        • zlib (madler/zlib, v1.3.1)
        • libpng (glennrp/libpng, v1.6.43)
    • Regression guard
      • Extended tests/test_renderer_font_build_lane_parity.py to assert these git-backed bootstrap calls exist.
    • Docs alignment
      • Updated BUILD.md and docs/build/windows.md to reflect automatic _deps source hydration via git + cmake.
Ensure-GitDependencySource -Name 'libogg' `
  -SourceDir $oggSourceDir `
  -RepositoryUrl 'https://github.com/xiph/ogg.git' `
  -Tag 'v1.3.5' `
  -RequiredPaths @(...)

Verification

  • I have run the relevant harness suites locally and attached the results below.
  • I have updated the project baselines when required and linked the diff below.
  • I have documented any syscall contract changes and linked the record below.

Required Links (fill every field or provide a justified N/A)

  • Harness run(s): N/A – issue scope is Windows build bootstrap in CI, not runtime harness behavior.
  • Baseline update diff: N/A – no gameplay/runtime baseline behavior changed.
  • Syscall contract edit log: N/A – no syscall boundaries or contracts changed.

Additional Notes

  • Expected impact: Windows modern compatibility package can now run from a fresh checkout without manual pre-population of src/libs/_deps.

Copilot AI changed the title [WIP] Fix failing GitHub Actions job Windows modern compatibility package Stabilize Windows modern compatibility package by auto-cloning missing codec sources Jun 9, 2026
Copilot AI requested a review from themuffinator June 9, 2026 07:50
@themuffinator themuffinator marked this pull request as ready for review June 9, 2026 12:16
@themuffinator themuffinator merged commit 06f6502 into main Jun 9, 2026
11 checks passed
@themuffinator themuffinator deleted the copilot/fix-windows-modern-compatibility-job branch June 9, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants