Keep Home data when add forms are canceled - #86
Merged
thermcampos merged 1 commit intoSep 26, 2026
Merged
Conversation
Owner
|
Thank you for the PR @humairaambreen ! I really appreciate it. I'm finishing a work that changes the note document rendering, I'll prioritize that, get it merged then look at this PR, since it doesn't touch what's being changed. I'll keep you posted :D |
Contributor
Author
|
Thanks for the update. That makes sense; I’m happy to wait until the rendering change is merged. Let me know if you need anything adjusted on this one. |
thermcampos
approved these changes
Sep 26, 2026
thermcampos
left a comment
thermcampos
left a comment
Owner
There was a problem hiding this comment.
Great PR! Clean. It looks amazing. 🥳 🚀
I see a small improvement in the signOut function but I can handle that in a follow up PR!
Thanks a ton!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Cancel from Add Task or Add Note, Home’s data hasn’t changed. Keep the last items and tags in memory and reuse them when Home mounts again, avoiding the extra requests.
A successful save still fetches fresh data. Deleting a task or note also refreshes tags so tags with no remaining items disappear. Cached responses are copied so Home’s in-place task translation cannot alter the stored data.
Closes #85.
Checks:
npm run test:no-watch -- --maxWorkers=1 --reporter=dot(150 passed)npm run lintnpm run build